Add clear ASCII warning banner summarizing blind-zone and lead time#12
Open
dewanggaabdullah wants to merge 1 commit into
Open
Add clear ASCII warning banner summarizing blind-zone and lead time#12dewanggaabdullah wants to merge 1 commit into
dewanggaabdullah wants to merge 1 commit into
Conversation
Author
|
Hi @tylrcc, I would like to let you know that my PR is ready for review. I look forward to your further instructions |
Author
|
Hi @tylrcc , I’m just following up on the task I completed last week. I wanted to drop a gentle reminder in case it slipped under your radar. I'm a bit concerned that leaving this PR open for too long might lead to disruptive merge conflicts. I would really appreciate some clear feedback so I know whether I need to make further adjustments to the code, or if my approach isn't quite what you're looking for. Here is the link:#12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
This PR addresses Issue #7 by adding a high-visibility ASCII warning banner inside
sim_main()intremormesh/cli.py.The new banner visually isolates and highlights the two critical metrics requested: blind-zone radius and warning lead time, making the output much more scannable for engineers at a glance when an alert is triggered. All existing lines have been kept exactly as they were to ensure that CI pipelines and automated testing remain completely unaffected.
Checklist
pytest -qpasses locallytremormesh/stalta.pyand4_Firmware/node/node.ino, plus the testsNotes for reviewers
Live Output Screenshots
I have prepared two visual approaches for the banner depending on your preference for the terminal UI:
Case 1: Compact Informative Box (Currently Active in Code)
This version provides a clean structured summary with an actionable evacuation notice for the simulation broadcast trigger.
Case 2: High-Visibility Large Text-Art (Alternative Layout)
This version uses a larger text-art style for the "WARNING" header to maximize attention.
The code is currently using Case 1 as I felt it keeps the CLI clean, but please let me know which style you prefer! I'm happy to swap it to Case 2 if you like that better. Thank you!